Skip to content

Remove explicit descriptor #9001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove explicit descriptor #9001

wants to merge 1 commit into from

Conversation

harishs88ss
Copy link

Summary: we only need this for constructors with one param

Differential Revision: D70630711

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Mar 6, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9001

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 48fa78d with merge base e673f7c (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

5 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@harishs88ss
Copy link
Author

@pytorchbot label "topic: not user facing"

@harishs88ss @facebook-github-bot
Remove explicit descriptor (pytorch#9001)
48fa78d 
Summary:

we only need this for constructors with one param

Reviewed By: JacobSzwejbka

Differential Revision: D70630711
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

3 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D70630711

@github-actions github-actions bot mentioned this pull request Mar 10, 2025
Open
This was referenced Mar 17, 2025
Open
Open
@github-actions github-actions bot mentioned this pull request Mar 31, 2025
Open
@github-actions github-actions bot mentioned this pull request Apr 7, 2025
Open
@github-actions GitHub Actions
Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the stale PRs inactive for over 60 days label Aug 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JacobSzwejbka JacobSzwejbka JacobSzwejbka approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported stale PRs inactive for over 60 days topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harishs88ss @facebook-github-bot @JacobSzwejbka