Skip to content

Conversation

fumchin
Copy link
Collaborator

@fumchin fumchin commented Mar 7, 2025

Refactored multiple operator test files:

  • Replaced @parameterized.expand with @common.parametrize.
  • Removed _test_*_pipeline() functions and replaced them with TosaPipelineMI and TosaPipelineBI.
  • Fixed padding handling for max pooling and avg pooling.
  • Updated pipeline infrastructure to simplify replacing the default quantize stage.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

@fumchin fumchin requested a review from digantdesai as a code owner March 7, 2025 16:26
Copy link

pytorch-bot bot commented Mar 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9039

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job

As of commit 5cf9bf9 with merge base 059e4b0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 7, 2025
@fumchin
Copy link
Collaborator Author

fumchin commented Mar 7, 2025

@pytorchbot label ciflow/trunk

@fumchin fumchin added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. ciflow/trunk partner: mediatek Issues related to the Mediatek delegate and removed ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: mediatek Issues related to the Mediatek delegate labels Mar 7, 2025
@fumchin fumchin force-pushed the refactor-ops-tests branch from ae38a22 to 7643953 Compare March 7, 2025 16:37
@fumchin fumchin changed the title Refactor Ops Tests: AvgPool, Clamp, Clone, Conv1d, Sub Arm backend: Refactor Ops Tests for AvgPool, Clamp, Clone, Conv1d, Sub Mar 7, 2025
@asparkhi
Copy link
Collaborator

@fumchin could you please rebase? 😸

@fumchin fumchin force-pushed the refactor-ops-tests branch 4 times, most recently from b3ffb55 to ff9182f Compare March 12, 2025 10:56
@fumchin
Copy link
Collaborator Author

fumchin commented Mar 12, 2025

@ashutosh-arm I have rebased the code! Thanks!

Refactored multiple operator test files:
- Replaced `@parameterized.expand` with `@common.parametrize`.
- Removed `_test_*_pipeline()` functions and replaced them with `TosaPipelineMI` and `TosaPipelineBI`.
- Fixed padding handling for max pooling and avg pooling.
- Updated pipeline infrastructure to simplify replacing the default quantize stage.

Signed-off-by: Fang-Ching <Fang-Ching.Chen@arm.com>
Change-Id: I5dd342584ef079b33463239e8e56726ce55bdc30
@zingo zingo force-pushed the refactor-ops-tests branch from 93e4aa2 to 5cf9bf9 Compare March 20, 2025 12:07
@zingo
Copy link
Collaborator

zingo commented Mar 20, 2025

MacOS fails unrelated

@zingo zingo merged commit 4894170 into pytorch:main Mar 20, 2025
161 of 163 checks passed
oscarandersson8218 pushed a commit to oscarandersson8218/executorch that referenced this pull request Mar 21, 2025
pytorch#9039)

Refactored multiple operator test files:
- Replaced `@parameterized.expand` with `@common.parametrize`.
- Removed `_test_*_pipeline()` functions and replaced them with
`TosaPipelineMI` and `TosaPipelineBI`.
- Fixed padding handling for max pooling and avg pooling.
- Updated pipeline infrastructure to simplify replacing the default
quantize stage.

Signed-off-by: Fang-Ching <Fang-Ching.Chen@arm.com>
DannyYuyang-quic pushed a commit to CodeLinaro/executorch that referenced this pull request Apr 2, 2025
pytorch#9039)

Refactored multiple operator test files:
- Replaced `@parameterized.expand` with `@common.parametrize`.
- Removed `_test_*_pipeline()` functions and replaced them with
`TosaPipelineMI` and `TosaPipelineBI`.
- Fixed padding handling for max pooling and avg pooling.
- Updated pipeline infrastructure to simplify replacing the default
quantize stage.

Signed-off-by: Fang-Ching <Fang-Ching.Chen@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants