Skip to content

removed temp memory from mean dim out #9052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2025
Merged

removed temp memory from mean dim out #9052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions backends/cadence/fusion_g3/operators/op_mean.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ Tensor& mean_out(
for (int i = 0; i < kNnlibMaxDim; i++) {
out_shape[i] = 1;
inp_shape[i] = 1;
p_axis[i] = 1;
p_axis[i] = -1;
}

int num_axis_dims = prepare_data(
Expand All @@ -135,20 +135,10 @@ Tensor& mean_out(
num_out_dims = 1;
}

int inp_shape_max = inp_shape[p_axis[0]];
for (int i = 1; i < num_axis_dims; i++) {
if (inp_shape[p_axis[i]] > inp_shape_max) {
inp_shape_max = inp_shape[p_axis[i]];
}
if ((out.dim() == 0) && (out.numel())) {
num_out_dims = 1;
}

int scratch_size = in.numel() / inp_shape_max;

executorch::runtime::Result<void*> temp_mem =
ctx.allocate_temp(scratch_size * sizeof(float));

void* __restrict__ p_scratch_in = (void* __restrict__)(temp_mem.get());

XT_KERNEL_CHECK(
ctx,
out,
Expand All @@ -160,8 +150,7 @@ Tensor& mean_out(
inp_shape,
num_inp_dims,
p_axis,
num_axis_dims,
p_scratch_in);
num_axis_dims);
} else {
ET_KERNEL_CHECK(
ctx,
Expand Down
Loading