[ET-VK][ez] Retry with no optimization during shader compilation #9096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Context In some cases, a shader can be compiled successfully with `glslc`, but if an optimization flag such as `-O` or `-Os` is used, the compilation will fail with a message similar to ``` internal error: compilation succeeded but failed to optimize: Invalid use of 8- or 16-bit result\n %133 = OpExtInst %half %1 Pow %125 %132 ``` Which will cause the shader compilation script to fail. This diff introduces a check that if `glslc` complains about not being able to optimize the SPIR-V, then retry compilation without optimization arguments. Differential Revision: [D70906097](https://our.internmc.facebook.com/intern/diff/D70906097/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9096
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f7d5a87 with merge base ddf0d9e ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D70906097 |
…lation" ## Context In some cases, a shader can be compiled successfully with `glslc`, but if an optimization flag such as `-O` or `-Os` is used, the compilation will fail with a message similar to ``` internal error: compilation succeeded but failed to optimize: Invalid use of 8- or 16-bit result\n %133 = OpExtInst %half %1 Pow %125 %132 ``` Which will cause the shader compilation script to fail. This diff introduces a check that if `glslc` complains about not being able to optimize the SPIR-V, then retry compilation without optimization arguments. Differential Revision: [D70906097](https://our.internmc.facebook.com/intern/diff/D70906097/) [ghstack-poisoned]
trivedivivek
approved these changes
Mar 11, 2025
facebook-github-bot
merged commit ebd14ad
into
gh/SS-JIA/194/base
49 of 50 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Mar 11, 2025
This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #9096 by @SS-JIA ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/194/orig @diff-train-skip-merge Co-authored-by: Stephen Jia <ssjia@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Context
In some cases, a shader can be compiled successfully with
glslc, but if an optimization flag such as-Oor-Osis used, the compilation will fail with a message similar toWhich will cause the shader compilation script to fail.
This diff introduces a check that if
glslccomplains about not being able to optimize the SPIR-V, then retry compilation without optimization arguments.Differential Revision: D70906097