Added params_require_grad arg to make_functional* #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou3519
reviewed
Apr 14, 2022
samdow
reviewed
Apr 14, 2022
vfdev-5
force-pushed
the
add-make_functional-grad-arg
branch
from
4d55614
to
cb1273a
Compare
zou3519
reviewed
Apr 22, 2022
vfdev-5
force-pushed
the
add-make_functional-grad-arg
branch
from
db662b1
to
a8830cf
Compare
samdow
reviewed
Apr 22, 2022
samdow
reviewed
Apr 22, 2022
samdow
approved these changes
Apr 22, 2022
vfdev-5
force-pushed
the
add-make_functional-grad-arg
branch
from
a8830cf
to
1340fb0
Compare
|
Merging since all of the failures look to be from upstream. Thanks for all your work on this @vfdev-5! |
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Jul 20, 2022
…h/functorch#701) * Added params_require_grad arg to make_functional* * Renamed arg to disable_params_grad * [skip ci] Updated docstring according to the review * Updated docstring func signature
bigfootjon
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Jul 21, 2022
…h/functorch#701) * Added params_require_grad arg to make_functional* * Renamed arg to disable_params_grad * [skip ci] Updated docstring according to the review * Updated docstring func signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #639 (comment)
Description:
params_require_gradargument tomake_functionalandmake_functional_with_buffers@samdow let me know if something else I'm missing for this PR. Thanks