-
Notifications
You must be signed in to change notification settings - Fork 340
gloo/types.h: include cstdint #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @sebastian-de! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixes unknown type name compile errors. Co-authored-by: Sumantro Mukherjee <saggy.zone@gmail.com>
Imported from GitHub PR #32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 FUTURE_COPYBARA_INTEGRATE_REVIEW=#32240 from medaminezghal:update-gloo e21bfd1 PiperOrigin-RevId: 816096443
Imported from GitHub PR openxla/xla#32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1161c26231f71299ccb7536098fcc16554 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#32240 from medaminezghal:update-gloo e21bfd1161c26231f71299ccb7536098fcc16554 PiperOrigin-RevId: 816096443
Imported from GitHub PR #32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 FUTURE_COPYBARA_INTEGRATE_REVIEW=#32240 from medaminezghal:update-gloo e21bfd1 PiperOrigin-RevId: 816096443
Imported from GitHub PR openxla/xla#32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1161c26231f71299ccb7536098fcc16554 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#32240 from medaminezghal:update-gloo e21bfd1161c26231f71299ccb7536098fcc16554 PiperOrigin-RevId: 816096443
Imported from GitHub PR #32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 COPYBARA_INTEGRATE_REVIEW=#32240 from medaminezghal:update-gloo e21bfd1 PiperOrigin-RevId: 817064773
Imported from GitHub PR openxla/xla#32240 📝 Summary of Changes Please provide a clear and concise summary of the changes you've made. Update Gloo to use [this commit](pytorch/gloo#452). 🎯 Justification Explain why this change is important and which workload benefits from this change. It make it compatible with GCC 15 build. 🚀 Kind of Contribution Please remove what does not apply: 🐛 Bug Fix, ✨ New Feature Copybara import of the project: -- e21bfd1161c26231f71299ccb7536098fcc16554 by Mohamed Amine Zghal <medaminezghal@outlook.com>: Update Gloo to fix build with GCC 15 Merging this change closes #32240 PiperOrigin-RevId: 817064773
fixes unknown type name compile errors.
clang-format'ed version of #448