Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to NNP-I v1.0.0.5 #4770

Closed
wants to merge 1 commit into from
Closed

Update to NNP-I v1.0.0.5 #4770

wants to merge 1 commit into from

Conversation

omromano
Copy link
Contributor

@omromano omromano commented Aug 3, 2020

Summary: Align code to NNP-I v1.0.0.5 (glow tracing changes).

@omromano
Copy link
Contributor Author

omromano commented Aug 3, 2020

Hi @jfix71, @arunm-git,
Please take a look.

Copy link
Contributor

@jfix71 jfix71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @omromano -- some tiny nits, but LGTM otherwise.

lib/Backends/NNPI/NNPIMLTraceWrapper.cpp Outdated Show resolved Hide resolved
lib/Backends/NNPI/NNPIMLTraceWrapper.cpp Outdated Show resolved Hide resolved
lib/Backends/NNPI/NNPIOptions.h Outdated Show resolved Hide resolved
lib/Backends/NNPI/NNPITracing.cpp Outdated Show resolved Hide resolved
lib/Backends/NNPI/NNPITracing.cpp Outdated Show resolved Hide resolved
lib/Backends/NNPI/NNPITracing.h Outdated Show resolved Hide resolved
@omromano
Copy link
Contributor Author

omromano commented Aug 4, 2020

Thanks @jfix71,
I have made the suggested changes.

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hl475 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Aug 12, 2020
Summary:
Align code to NNP-I v1.0.0.5 (glow tracing changes).

Pull Request resolved: pytorch/glow#4770

Reviewed By: arunm-git

Differential Revision: D22927904

Pulled By: hl475

fbshipit-source-id: 3746a6b07f3fcffc662d80a95513427cfccac7a5
@facebook-github-bot
Copy link

@hl475 merged this pull request in ab19f2f.

geoffberry pushed a commit to geoffberry/glow that referenced this pull request Nov 8, 2020
Summary:
Align code to NNP-I v1.0.0.5 (glow tracing changes).

Pull Request resolved: pytorch#4770

Reviewed By: arunm-git

Differential Revision: D22927904

Pulled By: hl475

fbshipit-source-id: 3746a6b07f3fcffc662d80a95513427cfccac7a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants