Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade torchvision version #214

Merged
merged 3 commits into from
Jul 22, 2021
Merged

upgrade torchvision version #214

merged 3 commits into from
Jul 22, 2021

Conversation

parmeet
Copy link
Contributor

@parmeet parmeet commented Jul 22, 2021

#212
#208

Upgrading torchvision md files to latest version 0.10.0

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for pytorch-hub-preview ready!

🔨 Explore the source changes: 3529967

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-hub-preview/deploys/60f97f1ea75ee40007698383

😎 Browse the preview: https://deploy-preview-214--pytorch-hub-preview.netlify.app/ecosystem

Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @parmeet , LGTM

Just curious, did you use ./scripts/upgrade_torchvision.sh to update?

Regarding the linked issues: I'm afraid this won't solve #212 or #208 yet. But pytorch/pytorch#61761 should fix them

@parmeet
Copy link
Contributor Author

parmeet commented Jul 22, 2021

Thanks @parmeet , LGTM

Just curious, did you use ./scripts/upgrade_torchvision.sh to update?

Regarding the linked issues: I'm afraid this won't solve #212 or #208 yet. But pytorch/pytorch#61761 should fix them

Sounds good! Thanks for mentioning the other related issue. Also yes, I used the script. Just that the script doesn't work out of the box on mac, here is the story why :)

@NicolasHug
Copy link
Member

Regarding the last commit: b631c29
It seems to be the same as #215. In order to keep unrelated changes separate, perhaps we should revert this commit and wait for #215 to be merged before merging this one?

@parmeet
Copy link
Contributor Author

parmeet commented Jul 22, 2021

Regarding the last commit: b631c29
It seems to be the same as #215. In order to keep unrelated changes separate, perhaps we should revert this commit and wait for #215 to be merged before merging this one?

unfortunately, the CircleCI testing exits on the first failure.. this was temporarily done to proceed to next testing. not sure, if we should do all the tests and catch all failures instead?

@parmeet parmeet merged commit eb65e62 into pytorch:master Jul 22, 2021
@parmeet parmeet deleted the vision_upgrade branch July 22, 2021 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants