Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some of the notebooks #314

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Fix some of the notebooks #314

merged 1 commit into from
Jan 9, 2023

Conversation

NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented Jan 7, 2023

Hopefully.

The list of jobs currently failing is: https://app.circleci.com/pipelines/github/pytorch/hub/2023/workflows/1fb1a4ce-17d5-45a7-b68a-1f92441072d0/jobs/2468

Also opened the following bugfix requests in other repos: #317

@netlify
Copy link

netlify bot commented Jan 7, 2023

Deploy Preview for pytorch-hub-preview ready!

Name Link
🔨 Latest commit 41f91f7
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-hub-preview/deploys/63b9897235234d000907a409
😎 Deploy Preview https://deploy-preview-314--pytorch-hub-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NicolasHug
Copy link
Member Author

NicolasHug commented Jan 8, 2023

@vmoens I think we can merge this PR now. It has fixed the datvuthanh_hybridnets.py issue, and also the pytorch_vision_snnmlp.py issue - which now still fails with the cuda dependency error (same as pytorch_vision_ghostnet.py as they're from the same repo).

I'll open an issue to keep track of the rest of the failures. EDIT: #317

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmoens vmoens merged commit ed58d27 into pytorch:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants