Skip to content

CycleGAN notebook is broken with updated ParamGroupScheduler #1249

@vfdev-5

Description

@vfdev-5

raise ValueError("schedulers should be related to same optimizer")

@sdesrozis above code brakes our cycle gan notebook where we do

gen_lr_scheduler = PiecewiseLinear(optimizer_D, param_name='lr', milestones_values=milestones_values)
desc_lr_scheduler = PiecewiseLinear(optimizer_G, param_name='lr', milestones_values=milestones_values)

lr_scheduler = ParamGroupScheduler([gen_lr_scheduler, desc_lr_scheduler], 
                                   names=['gen_lr_scheduler', 'desc_lr_scheduler'])

Can we simply remove that check ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions