Skip to content

Improved namings in _XlaDistModel #1173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2020
Merged

Improved namings in _XlaDistModel #1173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ignite/distributed/comp_models/xla.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ def create_from_context() -> Optional["_XlaDistModel"]:
return _XlaDistModel()

@staticmethod
def create_from_backend(backend: str = "xla-tpu", **kwargs) -> "_XlaDistModel":
def create_from_backend(backend: str = XLA_TPU, **kwargs) -> "_XlaDistModel":
return _XlaDistModel(backend=backend, **kwargs)

def __init__(self, backend=None, **kwargs):
Expand All @@ -57,7 +57,7 @@ def _create_from_backend(self, backend, **kwargs):
self._setup_attrs()

def _init_from_context(self):
self._backend = "xla-tpu"
self._backend = XLA_TPU
self._setup_attrs()

def _compute_nproc_per_node(self):
Expand Down Expand Up @@ -110,7 +110,7 @@ def spawn(
nproc_per_node: int = 1,
nnodes: int = 1,
node_rank: int = 0,
backend: str = "xla-tpu",
backend: str = XLA_TPU,
**kwargs
):
import os
Expand Down