Skip to content

fix for distributed proxy sampler runtime error #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2020
Merged

fix for distributed proxy sampler runtime error #1192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2edde9a
fix for distributed proxy sampler padding
ryanwongsa Jul 9, 2020
27dbc3d
fixed formatting
ryanwongsa Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ignite/distributed/auto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ def __iter__(self):
while len(indices) < self.total_size:
indices += list(self.sampler)

if len(indices) != self.total_size:
raise RuntimeError("{} vs {}".format(len(indices), self.total_size))
if len(indices) > self.total_size:
indices = indices[: self.total_size]

# subsample
indices = indices[self.rank : self.total_size : self.num_replicas]
Expand Down
23 changes: 14 additions & 9 deletions tests/ignite/distributed/test_auto.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,18 +155,23 @@ def test_dist_proxy_sampler():

weights = torch.ones(100)
weights[:50] += 1
num_samples = 100
num_samples = 200
sampler = WeightedRandomSampler(weights, num_samples)

num_replicas = 4
num_replicas = 8
dist_samplers = [DistributedProxySampler(sampler, num_replicas=num_replicas, rank=i) for i in range(num_replicas)]

torch.manual_seed(0)
true_indices = list(sampler)
for seed in range(100):
torch.manual_seed(seed)
true_indices = list(sampler)

indices_per_rank = []
for s in dist_samplers:
s.set_epoch(0)
indices_per_rank += list(s)
indices_per_rank = []
for s in dist_samplers:
s.set_epoch(seed)
indices_per_rank += list(s)

assert set(indices_per_rank) == set(true_indices)
set_indices_per_rank = set(indices_per_rank)
set_true_indices = set(true_indices)
assert set_indices_per_rank == set_true_indices, "{} | {}".format(
set_true_indices - set_indices_per_rank, set_indices_per_rank - set_true_indices
)