Skip to content

Conversation

@trsvchn
Copy link
Collaborator

@trsvchn trsvchn commented Oct 3, 2020

Fixes #1316

Description:

Novel tqdm's format_meter classmethod now uses tqdm initial parameter; by default it is set up to initial=0, but in tqdm_logger.py it overrides defaults to initial=1, that's why now we expect "?" instead of "00:00", since now we need to consider yet another parameter

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

Novel tqdm's `format_meter` classmethod now uses tqdm `initial` parameter; by default it is set up to `initial=0`, but in tqdm_logger.py it overrides defaults to `initial=1`, that's why now we expect "?" instead of "00:00", since now we need to consider yet another parameter
@vfdev-5
Copy link
Collaborator

vfdev-5 commented Oct 3, 2020

@trsvchn thanks for the PR and the analysis about initial=1! Currently, #1339 was the first PR to fix the same issue and most likely I'll merge it. Please, check our HF list of issues and feel free to pick one you like to tackle. Thanks !

@vfdev-5 vfdev-5 closed this Oct 4, 2020
@trsvchn trsvchn deleted the remove-tqdm-4.48.0 branch October 24, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove tqdm<=4.48.0 requirements

2 participants