-
-
Notifications
You must be signed in to change notification settings - Fork 658
HandlersTimeProfiler: add an example notebook showing usage #1474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Just want to add that, while modifying README I noticed that pre-commit was suggesting lot of whitespace related changes in the README. |
@harsh8398 thanks for the PR ! I was wondering if you also see the cell with printed results like below:
About the precommit, I think it should be related to #1468. Could you please dump the diff once with the precommit, maybe it is OK and just accept them ? |
@vfdev-5 Yes, I am seeing the same output. I was able to fix that spill by using the trick mentioned here. The output looks as follows now:
Sorry, I didn't get you. What are you suggesting? Do you want me to add those precommit changes in this PR? |
@sdesrozis could you please review the PR and merge if it is OK |
@harsh8398 Maybe we should add a line to install
What do you think ? There is a warning from
Could we remove it ? EDIT : mentioned points are not mandatory and should be addressed in PRs (others notebooks don't have install command and warning is not directly related to this work). |
… warning raised from time_profilers.py
@sdesrozis I have added the suggested cell at the top. Also, I've raised a PR(#1487) for the change required to remove the warning. |
@harsh8398 I think you didn't commit the good installation command line in notebook. Could you check and fix please ? |
@sdesrozis Sorry for that, Its fixed now. |
@harsh8398 Thank you LGTM ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Completes #1427
Description: