Skip to content

Removed size limitation for str on collective ops #1702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 25, 2021
Merged

Removed size limitation for str on collective ops #1702

merged 4 commits into from
Feb 25, 2021

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Feb 25, 2021 •
edited
Loading

Fixes #1697

Description:

  • Removed size limitation for str on collective ops: all_gather, broadcast
  • Added MIN, MAX, PRODUCT options for horovod all reduce
  • Added more distrib tests
  • minor consistency improvements

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@vfdev-5 vfdev-5 requested a review from sdesrozis February 25, 2021 09:51
sdesrozis
sdesrozis approved these changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@sdesrozis sdesrozis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vfdev-5 It looks good !

@sdesrozis sdesrozis merged commit 592f5b7 into pytorch:master Feb 25, 2021
@vfdev-5 vfdev-5 deleted the issue-1697-collective-op-str-1024 branch February 25, 2021 15:46
@vfdev-5 vfdev-5 mentioned this pull request Feb 25, 2021
Closed
vfdev-5 added a commit that referenced this pull request Mar 1, 2021
@vfdev-5
Removed size limitation for str on collective ops (#1702)
8ed0434 
* - Removed 1024 limitation for str on collective ops
- Added MIN, MAX, PRODUCT options for horovod all reduce
Fixes #1697

* Fixed failing test and added more tests
+ minor consistency fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sdesrozis sdesrozis sdesrozis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove 1024 limit for str on collective ops

2 participants

@vfdev-5 @sdesrozis