Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added state attributes for tqdm logger #2162

Merged
merged 5 commits into from
Aug 13, 2021
Merged

Added state attributes for tqdm logger #2162

merged 5 commits into from
Aug 13, 2021

Conversation

Ishan-Kumar2
Copy link
Contributor

@Ishan-Kumar2 Ishan-Kumar2 commented Aug 13, 2021 •
edited by vfdev-5
Loading

Fixes #2100 (and closing the issue)

Description:
Added state attributes for tqdm logger
Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the module: contrib Contrib module label Aug 13, 2021
vfdev-5
vfdev-5 approved these changes Aug 13, 2021
View reviewed changes
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! Thanks a lot @Ishan-Kumar2 !

@vfdev-5 vfdev-5 enabled auto-merge (squash) August 13, 2021 10:07
@vfdev-5 vfdev-5 merged commit 3eec6df into pytorch:master Aug 13, 2021
@Ishan-Kumar2 Ishan-Kumar2 deleted the tqdm_state_attrs branch August 13, 2021 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vfdev-5 vfdev-5 vfdev-5 approved these changes

Assignees
No one assigned
Labels
module: contrib Contrib module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update BaseOutputHandler to accept state attributes
2 participants
@Ishan-Kumar2 @vfdev-5