Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2325] Remove old docs related at https://pytorch.org/ignite/ #2432

Merged
merged 4 commits into from
Dec 26, 2022

Conversation

Moh-Yakoub
Copy link
Contributor

@Moh-Yakoub Moh-Yakoub commented Jan 18, 2022

Fixes #2325

Description: as discussed in #2325 we want to delete all old content that's not hosted on the new domain.

I've deleted all content that was replaced with the new domain and kept only the API reference docs as I couldn't find them in the new domain.

This is a WIP to use as a discussion forum till we agree on the optimal new design for the old doc page

To test it

1. cd docs
2. make html
3. cd build/
4. python -m http.server 8989

This is how it looks like

Screen Shot 2022-01-18 at 11 59 39 PM

Checked the links and they referencing the updated links instead of the old html.

I didn't change the main URL (https://pytorch.org/ignite') to the new URL because it will break the pages not available for the new URL (for instance: examples), will change the base to the new URL once all of the URLs are available on the (pytorch-ignite.ai/) URL

Check list:

  • New tests are added (if a new feature is added)
  • New doc strings: description and/or example code are in RST format
  • Documentation is updated (if required)

@github-actions github-actions bot added the docs label Jan 18, 2022
docs/source/index.rst Outdated Show resolved Hide resolved
docs/source/_templates/theme_variables.jinja Show resolved Hide resolved
docs/source/engine.rst Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 changed the title [WIP][#2325] Remove old docs related at https://pytorch.org/ignite/ [#2325] Remove old docs related at https://pytorch.org/ignite/ Dec 26, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR @Moh-Yakoub
Finally, we can merge it since all that time :)

@vfdev-5 vfdev-5 merged commit 00e7ea0 into pytorch:master Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update pytorch.org/ignite site and reference pytorch-ignite.ai
2 participants