Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issues related to mypy #2435

Merged
merged 6 commits into from
Jan 20, 2022
Merged

Fix for issues related to mypy #2435

merged 6 commits into from
Jan 20, 2022

Conversation

sayantan1410
Copy link
Contributor

Fixes #2361

Check list:

  • Bug Fix

Let me know if there is any mistake @vfdev-5

@github-actions github-actions bot added module: contrib Contrib module module: engine Engine module module: handlers Core Handlers module labels Jan 19, 2022
Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @sayantan1410
I left a question

@sayantan1410
Copy link
Contributor Author

@vfdev-5 I have tried to look at each of the error codes in the lines where the errors where generating, Let me know if I have made some mistake.

Copy link
Collaborator

@vfdev-5 vfdev-5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the update @sayantan1410 !
Let's see if mypy is passing and we can merge it.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 20, 2022

@sayantan1410 can you fix flake8 error:

+ flake8 ignite tests examples --config setup.cfg
ignite/handlers/checkpoint.py:721:36: W291 trailing whitespace

@sayantan1410
Copy link
Contributor Author

@vfdev-5 Sorry, probably there were two white spaces and I removed one and that's why it failed again, actually the extra white space did not show in my code editor.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 20, 2022

@sayantan1410 if you are using VSCode, you can trim extra white spaces with this option:

@vfdev-5 vfdev-5 enabled auto-merge (squash) January 20, 2022 13:53
@vfdev-5 vfdev-5 merged commit 111fc7a into pytorch:master Jan 20, 2022
@sayantan1410
Copy link
Contributor Author

@vfdev-5 Thank you so much for merging the PR.
Just a question, I saw this https://github.com/pytorch/ignite/runs/4883179036 test failing, can you tell me why it failed and why it was merged instead of a test failing ? Just curious to know.

@vfdev-5
Copy link
Collaborator

vfdev-5 commented Jan 20, 2022

@sayantan1410 failing test is codecov patch, this one is not always reliable indicator and we ignore it sometimes

@sayantan1410
Copy link
Contributor Author

@vfdev-5 Okay, thank you, also yes I was using VS Code and I changed the settings for trimming white spaces to true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: contrib Contrib module module: engine Engine module module: handlers Core Handlers module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix mypy issues with mypy==0.920
2 participants