Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'Open in Colab' button + highlighted packages in text #2887

Merged
merged 2 commits into from
Mar 13, 2023

Conversation

divij-pawar
Copy link
Contributor

These changes are for the file ignite/examples/notebooks/TextCNN.ipynb
Description:

  • Fixed the "Open in Colab" button.
  • Cleared up confusion regarding packages being installed in the first code block by highlighting 'torchtext' and 'spacy' as packages.

@github-actions github-actions bot added the examples Examples label Mar 12, 2023
@divij-pawar
Copy link
Contributor Author

Hey @sadra-barikbin. I have fixed the extra changes in 5d1657c .

Copy link
Collaborator

@sadra-barikbin sadra-barikbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @divij-pawar , LGTM!

@vfdev-5 vfdev-5 merged commit 55989f7 into pytorch:master Mar 13, 2023
@divij-pawar
Copy link
Contributor Author

This was my first issue! Thank you @sadra-barikbin for your patience and encouragement! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants