-
Notifications
You must be signed in to change notification settings - Fork 170
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make ITraceActivity::flowId return int64_t instead of int (#1019)
Summary: Pull Request resolved: #1019 RoctracerActivity::flowId and CuptiActivity::flowId return correlationId(), which is an int64. I think we had an instance (https://fburl.com/workplace/zzygx11m) of some correlationIds > 2**31, which was causing `ChromeTraceLogger::handleActivity` (in `output_json.cpp`) to skip writing the links here: ``` if (op.flowId() > 0) { handleGenericLink(op); } ``` Reviewed By: aaronenyeshi, sraikund16 Differential Revision: D66827501 fbshipit-source-id: 1dd8748a4b81c0e9d703fbc80a450c5d350617e7
- Loading branch information
1 parent
698c71c
commit a52ff32
Showing
4 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters