Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix namespace errors in PyTorch CI (#532)
Summary: Pull Request resolved: #532 PyTorch CI has some issues with the two namespaces such as Config defined in KINETO_NAMESPACE. Add using namespace to the failed areas. Test Plan: Fixes the errors on CI tests vulkan-bionic-py3.7-clang9, xenial-cuda11.3-py3.7-gcc7, xenial-py3.7-clang7-asan,xenial-py3.7-clang7-onnx, xenial-py3.7-gcc5.4, xenial-py3.7-gcc7, xenial-py3.6-gcc7-no-ops: ``` 2022-02-15T17:42:01.5120839Z In file included from /var/lib/jenkins/workspace/torch/csrc/autograd/profiler_kineto.cpp:23: 2022-02-15T17:42:01.5122878Z In file included from /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/libkineto.h:18: 2022-02-15T17:42:01.5123681Z In file included from /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/ActivityProfilerInterface.h:12: 2022-02-15T17:42:01.5125190Z /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/IActivityProfiler.h:92:13: error: unknown type name 'Config'; did you mean 'KINETO_NAMESPACE::Config'? 2022-02-15T17:42:01.5127932Z const Config& config) = 0; 2022-02-15T17:42:01.5128356Z ^~~~~~ 2022-02-15T17:42:01.5128871Z KINETO_NAMESPACE::Config 2022-02-15T17:42:01.5129844Z /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/Config.h:19:7: note: 'KINETO_NAMESPACE::Config' declared here 2022-02-15T17:42:01.5130467Z class Config : public AbstractConfig { 2022-02-15T17:42:01.5132737Z ^ 2022-02-15T17:42:01.5133430Z In file included from /var/lib/jenkins/workspace/torch/csrc/autograd/profiler_kineto.cpp:23: 2022-02-15T17:42:01.5134143Z In file included from /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/libkineto.h:18: 2022-02-15T17:42:01.5134920Z In file included from /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/ActivityProfilerInterface.h:12: 2022-02-15T17:42:01.5136267Z /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/IActivityProfiler.h:99:13: error: unknown type name 'Config'; did you mean 'KINETO_NAMESPACE::Config'? 2022-02-15T17:42:01.5162842Z const Config& config) = 0; 2022-02-15T17:42:01.5163525Z ^~~~~~ 2022-02-15T17:42:01.5165565Z KINETO_NAMESPACE::Config 2022-02-15T17:42:01.5166108Z /var/lib/jenkins/workspace/third_party/kineto/libkineto/include/Config.h:19:7: note: 'KINETO_NAMESPACE::Config' declared here 2022-02-15T17:42:01.5166657Z class Config : public AbstractConfig { 2022-02-15T17:42:01.5166901Z ^ 2022-02-15T17:42:01.5167612Z ``` Reviewed By: briancoutinho Differential Revision: D34249427 Pulled By: aaronenyeshi fbshipit-source-id: 77bc184715579cc16d615c652ffebf54232e972b
- Loading branch information