Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XPU] fix cmake can't find pti_view on Windows. #1012

Closed
wants to merge 4 commits into from
Closed

[XPU] fix cmake can't find pti_view on Windows. #1012

wants to merge 4 commits into from

Conversation

xuhancn
Copy link
Contributor

@xuhancn xuhancn commented Nov 7, 2024 •
edited
Loading

On Windows, we need to add version number to find pti_view:
Image

Local validate passed:
image

@xuhancn xuhancn marked this pull request as draft November 7, 2024 08:17
@xuhancn xuhancn marked this pull request as ready for review November 7, 2024 15:41
@xuhancn xuhancn changed the title fix cmake can't find pti_view on Windows. [XPU] fix cmake can't find pti_view on Windows. Nov 7, 2024
@xuhancn xuhancn marked this pull request as draft November 8, 2024 02:12
@sraikund16
Copy link
Contributor

@xuhancn is this ready or was it changed to draft for a specific reason?

@xuhancn
Copy link
Contributor Author

xuhancn commented Nov 19, 2024

Hi @sraikund16 we still internal discussed about if we need to get a lib list via a CMake var, we think it should be a better solution. So, I marked is as draft.

@xuhancn xuhancn marked this pull request as ready for review December 16, 2024 05:32
@xuhancn
Copy link
Contributor Author

xuhancn commented Dec 16, 2024

Hi @sraikund16 We discussed and decided to merge this PR. We can let it work and target to PyTorch release/2.7.
For CMake file optimization, we think it is nice to have work, and no plan for it now.
So, please help us merge this PR.

@facebook-github-bot
Copy link
Contributor

@sraikund16 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

sanrise
sanrise approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@sanrise sanrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, has some minor lint flags (shown in Phabricator).

@xuhancn
Copy link
Contributor Author

xuhancn commented Dec 17, 2024

LGTM, has some minor lint flags (shown in Phabricator).

@sanrise How to fix it?

@facebook-github-bot
Copy link
Contributor

@sraikund16 merged this pull request in bc1616a.

@xuhancn xuhancn deleted the xu_fix_find_pti_view_on_windows branch December 17, 2024 22:22
@xuhancn xuhancn mentioned this pull request Dec 17, 2024
Closed
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Dec 20, 2024
@xuhancn @pytorchmergebot
update kineto to XPU Windows fixed PR. [submodule kineto] (#143445)
2daa666 
Include XPU Windows Fixed PR: pytorch/kineto#1012

Pull Request resolved: #143445
Approved by: https://github.com/sraikund16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sraikund16 sraikund16 sraikund16 approved these changes

@sanrise sanrise sanrise approved these changes

Assignees
No one assigned
Labels
cla signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuhancn @sraikund16 @facebook-github-bot @sanrise