plugin: Fix hanging loading when no file exists #335
Conversation
Previous code was locking the requests from tb's `is_active` method until `_is_active` is set. However, it was also missing setting it to false when there is no related trace files. This fix basically sets the value to false if generator returns empty list, which will unlock tb request and return false.
|
@guotuofeng thanks for the feedback. Indeed it was the same fix with #326, sorry for the dupe. I understand that team wants to handle dynamic changes in the logdir after the plugin starts more properly (deletions do not seem to be handled right now for instance). I think that threading Event lock can even be completely removed with a better architecture. However, it might make this issue linger for a much longer period of time. Do you have an ETA for when would team implement the new exhaustive solution that would also fix this issue? It seems to me that this fix or #326 can act as a minimal hotfix change for a quick 0.2.1 release according to the project's release process. What do you think? |
|
If the is_active is set to false and there is some available data later, we have to manually press F5 in browser to allow the plugin be shown. On another hand, we are considering to make the is_active always return true to fix this issue and we don't have time to fully test it. |
|
I recognized the need for force refresh in my testing too. Also it makes much more sense to have an always active plugin and handle no data gracefully. I can live with this for now, thanks for the information! |
|
@manuyavuz, the #341 should be able to fix the bug. |
4 participants
Previous code was locking the requests from tb's
is_activemethod until_is_activeis set.However, it was also missing setting it to false when there is no related trace files.
This fix basically sets the value to false if generator returns empty list, which will unlock tb request and return false.
Fixes #334, tensorflow/tensorboard#5076, tensorflow/tensorboard#5111.