TB_Plugin_CI bug fix: add mpmath==1.3.0 to fix missing attribute rational #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54262113 |
…onal Summary: mpmath released a new version 1.4.0 on Feb 23. This version causes TB CI to have an error: `AttributeError: module 'mpmath' has no attribute 'rational'`. To fix the CI issue, we need to downgrade to an older version of mpmath 1.3.0. Fixes: pytorch#878 Differential Revision: D54262113 Pulled By: aaronenyeshi
aaronenyeshi
force-pushed
the
export-D54262113
branch
2 times, most recently
from
23cee11
to
f08ec63
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54262113 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D54262113 |
aaronenyeshi
requested review from
xuzhao9,
chaekit,
leitian,
davidberard98 and
briancoutinho
xuzhao9
approved these changes
Feb 27, 2024
|
Duplicate of pytorch/benchmark#2178, I thought this error has been fixed by https://github.com/pytorch/test-infra/pull/4948/files though. |
leitian
approved these changes
Feb 27, 2024
|
Landed in a4ae450 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: mpmath released a new version 1.4.0 on Feb 23. This version causes TB CI to have an error:
AttributeError: module 'mpmath' has no attribute 'rational'. To fix the CI issue, we need to downgrade to an older version of mpmath 1.3.0.Fixes: #878
Differential Revision: D54262113