update pybind to 2.10.2 #304
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@PaliC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
I opened a new PR to try v2.10.3 which is almost identical but turns the refcount debug utils off by default (until pybind111 2.11) and has some misc fixes. |
|
Hmm so it looks like there is some GIL issues. One common failure case we saw from this is trying store a python object as a global static variable (as the ctor would be called before the interpreter is initialized). |
|
Gotcha, will enable testing for #305 I'll take a look to see if there's any global static py::objects |
|
Hmm, are there atexit hooks in this codebase? I think there is an open issue with those that needs to be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to unblock pytorch/pytorch#91248 (comment) and the refcount debug utils will be useful :)