This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Change as_nested_tensor to only forward NestedTensor type #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
changed the title
izdeby
reviewed
May 20, 2020
|
|
||
|
|
||
| def as_nested_tensor(data, dtype=None, device=None): | ||
| # TODO: Needs tests to check failure cases |
There was a problem hiding this comment.
Because there is potentially a lot of edge cases
izdeby
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #150
as_nested_tensor now forwards NestedTensors only. This gets rid of the current view semantics of as_nested_tensor.