This repository was archived by the owner on Nov 15, 2022. It is now read-only.
Fixed cuda sync #183
Merged
Fixed cuda sync #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuhrsch
reviewed
Jun 17, 2020
benchmarks/segmentation_layers.py
Outdated
| @@ -135,7 +135,7 @@ def _batch_norm_nt(): | |||
| def max_pool2d_tensor_iter(self, module): | |||
| def _max_pool2d_tensor_iter(): | |||
| for t in self.inputs: | |||
| module(t.unsqueeze(0)).squeeze(0) | |||
| res = module(t.unsqueeze(0)).squeeze(0) | |||
There was a problem hiding this comment.
why not accumulate in a list? I'd imagine the garbage collector could still get rid of this the next iteration around since it's not referenced anymore.
There was a problem hiding this comment.
hmm. fair enough. let me try and see if behavior changes
There was a problem hiding this comment.
Didn't show any effect yet so removing these changes for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug with not passing cuda argument to benchmarks.