-
Notifications
You must be signed in to change notification settings - Fork 21
Enable CPU benchmark for VLLM perf dashboard #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Huy Do <huydhn@gmail.com>
Yeah, the step to setup the benchmark need a tweak per my comment in #39 (comment). When the device is CPU, it looks for file with |
| 2: [ | ||
| "linux.aws.h100.4", | ||
| "linux.rocm.gpu.mi300.2", | ||
| "linux.24xl.spr-metal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
24xlarge have only 1 NUMA node, so we should not put it under TP=2
Co-authored-by: Louie Tsai <louie.tsai@intel.com>
|
Hi @huydhn - we would like to enable this for AArch64 too (linux.arm64.m7g.metal) |
I could grant you that permission, but want to check what it is needed for. I thought that submitting a PR like this one would be sufficient? We do have |
|
@huydhn I think we mean permissions to trigger the workflow for dashboard?
|
Ah ok, got it. Ping me on vLLM Slack with the usernames, I could help grant the permission that you need |


Pick up the work on #39 to support CPU benchmark. The PR is more involved than I expect, and the list of changes include:
cuda,rocm, andcpu.github/scripts/generate_vllm_benchmark_matrix.pyto read from the correct folder from (1).github/scripts/test_generate_vllm_benchmark_matrix.pyfor (2) because it's pretty complex now.github/scripts/setup_vllm_benchmark.pyto copy from the correct folder from (1)linux.24xl.spr-metalto run CPU benchmark until Intel's runner is readypublic.ecr.aws/q9t5s3a7/vllm-ci-postmerge-repo:<HEAD_SHA>-cpuON_CPUto vLLM benchmark scripttorch.cuda.get_device_name()in.github/scripts/upload_benchmark_results.pybecause there is no CUDA device on CPUTesting
https://github.com/pytorch/pytorch-integration-testing/actions/runs/16231541112
cc @louie-tsai