Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.11.0 modifying release matrix #959

Merged
merged 4 commits into from
Mar 10, 2022
Merged

Release 1.11.0 modifying release matrix #959

merged 4 commits into from
Mar 10, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Mar 7, 2022

Release 1.11.0 modifying release matrix https://pytorch.org/get-started/locally/

@netlify
Copy link

netlify bot commented Mar 7, 2022 •
edited
Loading

👷 Deploy Preview for pytorch-dot-org-preview processing.

🔨 Explore the source changes: 6ccc34e

🔍 Inspect the deploy log: https://app.netlify.com/sites/pytorch-dot-org-preview/deploys/622a254ef35ce700091f0fcd

malfet
malfet reviewed Mar 7, 2022
View reviewed changes
published_versions.json
@@ -58,7 +58,7 @@
"cuda11.x": {
"note": null,
"versions": {
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu1133/libtorch-shared-with-deps-latest.zip",
"Download here (Pre-cxx11 ABI):": "https://download.pytorch.org/libtorch/nightly/cu113/libtorch-shared-with-deps-latest.zip",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow!

malfet
malfet requested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update matrix to indicate that 10.2 is missing on Windows

published_versions.json Outdated Show resolved Hide resolved
published_versions.json Outdated Show resolved Hide resolved
published_versions.json Outdated Show resolved Hide resolved
@brianjo brianjo requested a review from ezyang March 9, 2022 19:45
@ezyang
Copy link
Contributor

ezyang commented Mar 9, 2022

The Mac instructions for M1 users are not correct on the current live site; they need to install from -c conda-forge and not -c pytorch. Not sure if it applies here!

@ezyang
Copy link
Contributor

ezyang commented Mar 9, 2022

OK it looks wrong on the Netlify preview. My recommendation is probably to have separate OS X and OS X (M1) operating system tabs

@atalman atalman closed this Mar 10, 2022
@atalman atalman reopened this Mar 10, 2022
@atalman
Copy link
Contributor Author

atalman commented Mar 10, 2022

The Mac instructions for M1 users are not correct on the current live site; they need to install from -c conda-forge and not -c pytorch. Not sure if it applies here!

@ezyang I think we have eliminated conda-forge dependencies, but let me check

@malfet
Copy link
Contributor

malfet commented Mar 10, 2022

@ezyang perhaps we need to add a comment in Conda MacOS instructions that they are currently for x86_64 only

malfet
malfet reviewed Mar 10, 2022
View reviewed changes
published_versions.json Outdated Show resolved Hide resolved
atalman and others added 2 commits March 10, 2022 11:09
@atalman @malfet
Update published_versions.json
e737d72 
Co-authored-by: Nikita Shulga <nikita.shulga@gmail.com>
@atalman
Update quick-start-module
6ccc34e
@atalman atalman merged commit 73bb49a into pytorch:site Mar 10, 2022
@ezyang
Copy link
Contributor

ezyang commented Mar 11, 2022

@malfet IDK, I just know when I installed it from conda-forge it worked! (somehow)

@atalman atalman mentioned this pull request Mar 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malfet malfet malfet requested changes

@ezyang ezyang Awaiting requested review from ezyang

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atalman @ezyang @malfet @facebook-github-bot