Skip to content

Run ONNX tests as part of the standard run_test script #98626

Closed
@huydhn

Description

@huydhn

🐛 Describe the bug

At the moment, ONNX tests are handled in a different way than other Python test using run_test.py. Specifically, it shells out to pytest directly in https://github.com/pytorch/pytorch/blob/master/scripts/onnx/test.sh. The main issue with the current approach is that none of the feature of run_test.py is available to ONNX such as flaky bot, retry, slow test to name a fews. For example, it won't work when I try to disable a flaky ONNX test #98622. Now that run_test.py uses pytest by default, it's time to have onnx as part of it too

Versions

PyTorch CI, ONNX

cc @seemethere @malfet @pytorch/pytorch-dev-infra @ZainRizvi @kit1980 @clee2000

Metadata

Metadata

Assignees

Labels

ciflow/periodicTrigger jobs ran periodically on master (periodic.yml) on the PRmodule: ciRelated to continuous integrationmodule: devxRelated to PyTorch contribution experience (HUD, pytorchbot)module: onnxRelated to torch.onnxtriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate module

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions