Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert that we can compute the bounds for guards using rational numbers #105139

Closed
wants to merge 8 commits into from

Conversation

lezcano
Copy link
Collaborator

@lezcano lezcano commented Jul 13, 2023

Stack from ghstack (oldest at bottom):

This makes sure that the bounds are always correct, as we're not losing
precision

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jul 13, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/105139

Note: Links to docs will display an error until the docs builds have been completed.

✅ 2 Unrelated Failures

As of commit eca0416:

BROKEN TRUNK - The following job failed but were present on the merge base a63f3f4:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job failed but was likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jul 13, 2023
This makes sure that the bounds are always correct, as we're not lossing
precision

ghstack-source-id: 5baaafe61dc955bae5cab9a479abe9f6cd936618
Pull Request resolved: #105139
@lezcano lezcano requested a review from ezyang July 13, 2023 21:33
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
…ional numbers"

This makes sure that the bounds are always correct, as we're not lossing
precision

[ghstack-poisoned]
lezcano added a commit that referenced this pull request Jul 15, 2023
This makes sure that the bounds are always correct, as we're not lossing
precision

ghstack-source-id: 75fe4206f3d35b0c3721bc2060bf5d602f4c1e0a
Pull Request resolved: #105139
@lezcano
Copy link
Collaborator Author

lezcano commented Jul 17, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 17, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/Lezcano/214/head branch July 20, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: fx release notes category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants