Use fast traceback for symbolic shapes #107439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/107439
Note: Links to docs will display an error until the docs builds have been completed. ✅ 1 Unrelated FailureAs of commit afb6aa4 with merge base bdecdfd ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Aug 18, 2023
github-actions
bot
requested review from
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
SherlockNoMad,
voznesenskym and
wconstab
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Aug 18, 2023
ghstack-source-id: d48f6fa85bd6a7571bce58d6a9548f4f2682573c Pull Request resolved: #107439
[ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
Aug 18, 2023
ghstack-source-id: 5674a71c8c0d34bd7104ad0dfa972ee6fc01ba5b Pull Request resolved: #107439
[ghstack-poisoned]
This was referenced Aug 21, 2023
| @@ -126,8 +126,7 @@ class GuardBuilderBase: | |||
|
|
|||
| class ShapeGuard(NamedTuple): | |||
| expr: sympy.Expr | |||
| # TODO: store this in slightly less formatted form | |||
| stack: str | |||
| stack: CapturedTraceback | |||
voznesenskym
approved these changes
Aug 21, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):