Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use size on TensorVariable when doing out resize test #120567

Closed
wants to merge 2 commits into from

Conversation

ezyang
Copy link
Contributor

@ezyang ezyang commented Feb 24, 2024

Fixes #120482

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Feb 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/120567

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit c4f061f with merge base 36c1cc9 (image):

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Fixes #120482

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 aakhundov kadeng

[ghstack-poisoned]
ezyang added a commit that referenced this pull request Feb 24, 2024
Fixes #120482

Signed-off-by: Edward Z. Yang <ezyangmeta.com>

ghstack-source-id: 90e14c4c06fffc55729fabb10e29c0c57f7b9809
Pull Request resolved: #120567
@ezyang
Copy link
Contributor Author

ezyang commented Feb 24, 2024

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 24, 2024
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator

This is probably a good backport candidate for the next 2.2 bugfix.

@ezyang ezyang added this to the 2.2.2 milestone Feb 24, 2024
@atalman
Copy link
Contributor

atalman commented Mar 5, 2024

@pytorchbot cherry-pick --onto release/2.2 -c regression --fixes #120511

pytorchbot pushed a commit that referenced this pull request Mar 5, 2024
Fixes #120482
Fixes #120511

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #120567
Approved by: https://github.com/Skylion007

(cherry picked from commit 0f20cc1)
@pytorchbot
Copy link
Collaborator

Cherry picking #120567

The cherry pick PR is at #121232 and it is recommended to link a regression cherry pick PR with an issue

Details for Dev Infra team Raised by workflow job

atalman pushed a commit that referenced this pull request Mar 7, 2024
Fixes #120482
Fixes #120511

Signed-off-by: Edward Z. Yang <ezyang@meta.com>

Pull Request resolved: #120567
Approved by: https://github.com/Skylion007

(cherry picked from commit 0f20cc1)

Co-authored-by: Edward Z. Yang <ezyang@meta.com>
@github-actions github-actions bot deleted the gh/ezyang/2580/head branch April 11, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants