[Not for Landing] Update FBGEMM to the latest version with VNNI instruction support and latest ASMJIT version #24051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jianyuh
changed the title
jianyuh
changed the title
|
The newer version of FBGEMM with the latest ASMJIT (After the CMake fix: asmjit/asmjit#252) is not going to break OSS build. We are going to ship this PR (pytorch/FBGEMM#114) in FBGEMM. |
|
The reason for the conflict: we have a recent update in FBGEMM (pytorch/FBGEMM#112), which triggered a commit ID update in PyTorch. This conflict will be resolved by rebase. |
|
Close this PR as we have landed the FBGEMM PR (pytorch/FBGEMM#114) and this FBGEMM commit ID has been updated in a6c3a95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to update FBGEMM with VNNI instruction support and newer version of ASMJIT support:
pytorch/FBGEMM#114
The CMake version incompatibility issue has been resolved in
asmjit/asmjit#252
This PR is purely for checking if our FBGEMM PR (pytorch/FBGEMM#114) will break PyTorch OSS test. It is not intended for landing.