add a fast path for EmbeddingBag calling FBGEMM #36679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
xing-liu
pushed a commit
that referenced
this pull request
Apr 15, 2020
ghstack-source-id: 65c106e68c7200d6ab97ce159321b52c4c1ae26f Pull Request resolved: #36679
💊 Build failures summary and remediationsAs of commit 15551e9 (more details on the Dr. CI page):
XLA failureJob pytorch_xla_linux_bionic_py3_6_clang9_build is failing. Please create an issue with title prefixed by This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 9 times. |
[ghstack-poisoned]
xing-liu
pushed a commit
that referenced
this pull request
Apr 15, 2020
ghstack-source-id: 80bdc216e50e3344276f7b47b7fea0df9193ccd2 Pull Request resolved: #36679
jianyuh
reviewed
Apr 16, 2020
| @@ -5,7 +5,11 @@ | |||
|
|
|||
| #include <TH/THBlasUtils.h> | |||
|
|
|||
| #if defined(USE_FBGEMM) | |||
There was a problem hiding this comment.
Nit: for simplicity:
#ifdef USE_FBGEMM
Differential Revision: [D21058034](https://our.internmc.facebook.com/intern/diff/D21058034) [ghstack-poisoned]
xing-liu
added a commit
that referenced
this pull request
Apr 16, 2020
ghstack-source-id: b8013d2f053dfca8a34d2f772e92b82a715866e9 Pull Request resolved: #36679
Differential Revision: [D21058034](https://our.internmc.facebook.com/intern/diff/D21058034) [ghstack-poisoned]
xing-liu
added a commit
that referenced
this pull request
Apr 16, 2020
ghstack-source-id: aa4ff23c9efc402519bca9f510ecd8f83211c0ba Pull Request resolved: #36679
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D21058034