Do not add special CUDNN search path rules for torch_python
#37349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 Build failures summary and remediationsAs of commit aa3dd9c (more details on the Dr. CI page):
1 failure confirmed as flaky and can be ignored:
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 7 times. |
malfet
changed the title
CUDNN search path rules for torch_python
kostmo
requested changes
Apr 27, 2020
malfet
force-pushed
the
malfet/test-delete-cuda-rules
branch
from
a828558 to
aa3dd9c
Compare
|
Updated PR by deleting 2nd commit. |
|
Another interesting observation: before the change Before: |
ezyang
approved these changes
Apr 27, 2020
There was a problem hiding this comment.
@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those rules never worked until #37275 and afterwards they are causing crashes in manywheels builds, because getting
cudnnlinked intolibtorch_pythonandlibtorch_cudacauses double-free exceptions, see: https://app.circleci.com/pipelines/github/pytorch/pytorch/160350/workflows/85696e1c-1e67-4780-8ceb-18bc0a614507/jobs/5254443Test Plan: Enable
manywheelsbuild by temporarily enablingmanywheelsbuild on this PR and validate that it fixes the issue, see https://app.circleci.com/pipelines/github/pytorch/pytorch/160796/workflows/13227fbc-97c0-47f6-9a87-e840e1a4b5de/jobs/5267315/steps