support flip and rot90 for complex dtype #37826

kshitij12345 · 2020-05-05T15:52:47Z

Closes #37698

kshitij12345 · 2020-05-05T15:53:07Z

@anjali411 @dylanbespalko Please review.

dr-ci · 2020-05-05T16:51:57Z

💊 CI failures summary and remediations

As of commit 12c3762 (more details on the Dr. CI page):

1/1 failures possibly* introduced in this PR
- 1/1 non-CircleCI failure(s)

ci.pytorch.org: 1 failed

Failed: pr/caffe2-py3.6-devtoolset7-rocmrpm-centos7-test

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 83 times.

test/test_torch.py

aten/src/ATen/native/TensorTransformations.cpp

aten/src/ATen/native/cuda/TensorTransformations.cu

test/test_torch.py

anjali411 · 2020-05-07T17:45:24Z

@kshitij12345 any updates?

kshitij12345 · 2020-05-07T19:06:55Z

@kshitij12345 any updates?

Hi,
Apologies for the delayed response.
Will address the comments before Saturday.

test/test_torch.py

mruberry

Looking pretty good but a few questions/suggestions.

kshitij12345 · 2020-05-12T05:05:12Z

@pytorchbot retest this please!

kshitij12345 · 2020-05-14T19:37:53Z

@mruberry @anjali411 PTAL:)

test/test_torch.py

tensor_op_tests compare device result with cpu result. So there is no point in having dtypes for CPU to compare against itself.

* add `rtol=0` in assertEqual call.

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

mruberry · 2020-05-29T03:02:40Z

The Vander test failures are real:

May 29 01:19:45 ======================================================================
May 29 01:19:45 ERROR [0.037s]: test_vander_complex_types_cuda_complex128 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11931, in test_vander_complex_types
May 29 01:19:45     pt_res = torch.vander(pt_x, increasing=inc) if n is None else torch.vander(pt_x, n, inc)
May 29 01:19:45 RuntimeError: "cumprod_cuda" not implemented for 'ComplexDouble'
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 ERROR [0.038s]: test_vander_complex_types_cuda_complex64 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11931, in test_vander_complex_types
May 29 01:19:45     pt_res = torch.vander(pt_x, increasing=inc) if n is None else torch.vander(pt_x, n, inc)
May 29 01:19:45 RuntimeError: "cumprod_cuda" not implemented for 'ComplexFloat'
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_bool (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_float32 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_float64 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.032s]: test_vander_types_cuda_int16 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_int32 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.032s]: test_vander_types_cuda_int64 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_int8 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ======================================================================
May 29 01:19:45 FAIL [0.031s]: test_vander_types_cuda_uint8 (__main__.TestTorchDeviceTypeCUDA)
May 29 01:19:45 ----------------------------------------------------------------------
May 29 01:19:45 Traceback (most recent call last):
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_utils.py", line 798, in wrapper
May 29 01:19:45     method(*args, **kwargs)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 234, in instantiated_test
May 29 01:19:45     result = test(self, device_arg, dtype)
May 29 01:19:45   File "/opt/conda/lib/python3.6/site-packages/torch/testing/_internal/common_device_type.py", line 501, in only_fn
May 29 01:19:45     return fn(self, device, *args, **kwargs)
May 29 01:19:45   File "test_torch.py", line 11903, in test_vander_types
May 29 01:19:45     else torch.vander(pt_x, n, inc)
May 29 01:19:45 AssertionError: RuntimeError not raised
May 29 01:19:45 
May 29 01:19:45 ----------------------------------------------------------------------

test/test_torch.py

kshitij12345 · 2020-05-29T10:23:53Z

@mruberry
I think we should wait for #39063 to land, as it will add complex support for cumprod which would break the vander test (with Runtime Error not raised).

Instead we should rebase with the master once it is in and test the CUDA as well.

mruberry · 2020-05-29T14:42:54Z

@mruberry
I think we should wait for #39063 to land, as it will add complex support for cumsum which would break the vander test (with Runtime Error not raised).

Instead we should rebase with the master once it is in and test the CUDA as well.

Sounds good to me! Please re-request review when that happens.

…t/complex/flip-rot90

kshitij12345 · 2020-05-29T20:03:47Z

@mruberry

Have merged with the latest master thus vander now supports complex on CUDA.
Have merged the complex vander test with the existing one.

Do review. Thanks.

mruberry

Awesome!

facebook-github-bot

@mruberry has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

kshitij12345 · 2020-06-02T17:14:22Z

@mruberry Gentle ping

mruberry · 2020-06-02T18:22:12Z

@mruberry Gentle ping

Thanks @kshitij12345, internal tests looked good. I'll start landing now.

mruberry · 2020-06-02T20:06:32Z

Diff is landed and tests are now running on OSS Master to validate.

facebook-github-bot · 2020-06-02T20:16:49Z

@mruberry merged this pull request in 09bea13.

mruberry · 2020-06-03T02:41:03Z

Awesome! OSS Master validation tests look good.

kshitij12345 · 2020-06-03T05:15:16Z

Great! Thanks.

Will rebase #38599 and add tests.
Will ping you once ready.

pytorchbot added the open source label May 5, 2020

anjali411 reviewed May 5, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

anjali411 reviewed May 5, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

anjali411 reviewed May 5, 2020

View reviewed changes

test/test_torch.py Show resolved Hide resolved

anjali411 reviewed May 5, 2020

View reviewed changes

aten/src/ATen/native/TensorTransformations.cpp Show resolved Hide resolved

anjali411 reviewed May 5, 2020

View reviewed changes

aten/src/ATen/native/cuda/TensorTransformations.cu Show resolved Hide resolved

mruberry added module: complex Related to complex number support in PyTorch triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 5, 2020

mruberry reviewed May 5, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

mruberry reviewed May 5, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

kshitij12345 force-pushed the support/complex/flip-rot90 branch 2 times, most recently from 0de9bb7 to db22d61 Compare May 8, 2020 19:12

kshitij12345 requested review from anjali411 and mruberry May 8, 2020 21:36

mruberry reviewed May 10, 2020

View reviewed changes

test/test_torch.py Show resolved Hide resolved

mruberry reviewed May 10, 2020

View reviewed changes

test/test_torch.py Show resolved Hide resolved

mruberry reviewed May 10, 2020

View reviewed changes

test/test_torch.py Show resolved Hide resolved

mruberry reviewed May 10, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

mruberry self-requested a review May 10, 2020 10:53

mruberry requested changes May 10, 2020

View reviewed changes

kshitij12345 force-pushed the support/complex/flip-rot90 branch 2 times, most recently from c755485 to 1e0623b Compare May 14, 2020 16:37

mruberry reviewed May 15, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

mruberry self-requested a review May 15, 2020 22:10

kshitij12345 added 4 commits May 29, 2020 02:39

use _cpu_dtypes

76e73a2

tensor_op_tests compare device result with cpu result. So there is no point in having dtypes for CPU to compare against itself.

address comment

8132979

update complex dispatch macro

be0fa44

address comment

de42c5d

* add `rtol=0` in assertEqual call.

kshitij12345 force-pushed the support/complex/flip-rot90 branch from b01d217 to de42c5d Compare May 28, 2020 21:12

facebook-github-bot reviewed May 28, 2020

View reviewed changes

mruberry reviewed May 29, 2020

View reviewed changes

test/test_torch.py Outdated Show resolved Hide resolved

move condition to correct test

8cbe72f

kshitij12345 added 4 commits May 29, 2020 22:26

Merge branch lastest 'master' with complex cumsum support into suppor…

26d8633

…t/complex/flip-rot90

enable cuda test for vander complex

75bc204

merge complex test with the existing test

b207e2a

fix stray space

12c3762

kshitij12345 requested a review from mruberry May 29, 2020 20:01

mruberry approved these changes May 30, 2020

View reviewed changes

facebook-github-bot reviewed May 30, 2020

View reviewed changes

facebook-github-bot closed this in 09bea13 Jun 2, 2020

facebook-github-bot added the merged label Jun 2, 2020

kshitij12345 deleted the support/complex/flip-rot90 branch June 3, 2020 05:13

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support flip and rot90 for complex dtype #37826

support flip and rot90 for complex dtype #37826

kshitij12345 commented May 5, 2020

kshitij12345 commented May 5, 2020 •

edited

Loading

dr-ci bot commented May 5, 2020 •

edited

Loading

anjali411 commented May 7, 2020

kshitij12345 commented May 7, 2020

mruberry left a comment

kshitij12345 commented May 12, 2020

kshitij12345 commented May 14, 2020

facebook-github-bot left a comment

mruberry commented May 29, 2020

kshitij12345 commented May 29, 2020 •

edited

Loading

mruberry commented May 29, 2020

kshitij12345 commented May 29, 2020

mruberry left a comment

facebook-github-bot left a comment

kshitij12345 commented Jun 2, 2020

mruberry commented Jun 2, 2020

mruberry commented Jun 2, 2020

facebook-github-bot commented Jun 2, 2020

mruberry commented Jun 3, 2020

kshitij12345 commented Jun 3, 2020

support flip and rot90 for complex dtype #37826

support flip and rot90 for complex dtype #37826

Conversation

kshitij12345 commented May 5, 2020

kshitij12345 commented May 5, 2020 • edited Loading

dr-ci bot commented May 5, 2020 • edited Loading

💊 CI failures summary and remediations

ci.pytorch.org: 1 failed

anjali411 commented May 7, 2020

kshitij12345 commented May 7, 2020

mruberry left a comment

Choose a reason for hiding this comment

kshitij12345 commented May 12, 2020

kshitij12345 commented May 14, 2020

facebook-github-bot left a comment

Choose a reason for hiding this comment

mruberry commented May 29, 2020

kshitij12345 commented May 29, 2020 • edited Loading

mruberry commented May 29, 2020

kshitij12345 commented May 29, 2020

mruberry left a comment

Choose a reason for hiding this comment

facebook-github-bot left a comment

Choose a reason for hiding this comment

kshitij12345 commented Jun 2, 2020

mruberry commented Jun 2, 2020

mruberry commented Jun 2, 2020

facebook-github-bot commented Jun 2, 2020

mruberry commented Jun 3, 2020

kshitij12345 commented Jun 3, 2020

kshitij12345 commented May 5, 2020 •

edited

Loading

dr-ci bot commented May 5, 2020 •

edited

Loading

kshitij12345 commented May 29, 2020 •

edited

Loading