Kill resize-ing and zero-ing from codegen. #37958

gchanan · 2020-05-06T20:00:17Z

Stack from ghstack:

Move (most) generated return statements for TH functions out of the switch. #38073 Move (most) generated return statements for TH functions out of the switch.
Remove codegen for IntArrayRefStride, which isn't used. #38072 Remove codegen for IntArrayRefStride, which isn't used.
Macro generate ScalarTypeToCPPType, including all ScalarTypes. #38071 Macro generate ScalarTypeToCPPType, including all ScalarTypes.
Kill resize-ing and zero-ing from codegen. #37958 Kill resize-ing and zero-ing from codegen.

All codegen invocations have been removed at this point, so this has no effect.

Differential Revision: D21433215

All codegen invocations have been removed at this point, so this has no effect. [ghstack-poisoned]

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 17c9ff1 Pull Request resolved: #37958

dr-ci · 2020-05-06T20:53:39Z

💊 CI failures summary and remediations

As of commit f3f95bf (more details on the Dr. CI page):

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

See how this bot performed.

This comment has been revised 38 times.

bhosmer · 2020-05-06T21:35:33Z

aten/src/ATen/nn_parse.py

-        if arg['name'] == 'grad_weight' and base['name'] != '_thnn_conv2d' and base['name'] != '_thnn_conv_depthwise2d':
-            arg['resize'] = 'weight'
-            arg['zero'] = True
-        if arg['name'] == 'grad_bias' and base['name'] != '_thnn_conv2d' and base['name'] != '_thnn_conv_depthwise2d':


hahahahah NEVER MIND EARLIER COMMENTS

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 5ce0c2f Pull Request resolved: #37958

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 90b063b Pull Request resolved: #37958

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

facebook-github-bot · 2020-05-11T16:25:04Z

@gchanan merged this pull request in c26dde9.

Kill resize-ing and zero-ing from codegen.

a032940

All codegen invocations have been removed at this point, so this has no effect. [ghstack-poisoned]

This was referenced May 6, 2020

Move resize logic for bmm from codegen to native code. #37955

Closed

Move _thnn_conv2d resize and zero code from codegen to native code. #37956

Closed

Move resize / zero logic for _thnn_conv_depthwise2d from codegen to native code. #37957

Closed

gchanan added a commit that referenced this pull request May 6, 2020

Kill resize-ing and zero-ing from codegen.

a67b463

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 17c9ff1 Pull Request resolved: #37958

gchanan requested a review from bhosmer May 6, 2020 20:13

bhosmer approved these changes May 6, 2020

View reviewed changes

Update on "Kill resize-ing and zero-ing from codegen."

971b7e4

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

gchanan added a commit that referenced this pull request May 7, 2020

Kill resize-ing and zero-ing from codegen.

c515cdd

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 5ce0c2f Pull Request resolved: #37958

Update on "Kill resize-ing and zero-ing from codegen."

e54595b

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

gchanan added a commit that referenced this pull request May 7, 2020

Kill resize-ing and zero-ing from codegen.

1be3594

All codegen invocations have been removed at this point, so this has no effect. ghstack-source-id: 90b063b Pull Request resolved: #37958

This was referenced May 7, 2020

Macro generate ScalarTypeToCPPType, including all ScalarTypes. #38068

Closed

Remove codegen for IntArrayRefStride, which isn't used. #38069

Closed

Move (most) generated return statements for TH functions out of the switch. #38070

Closed

Update on "Kill resize-ing and zero-ing from codegen."

d98ddc1

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

This was referenced May 7, 2020

Macro generate ScalarTypeToCPPType, including all ScalarTypes. #38071

Closed

Remove codegen for IntArrayRefStride, which isn't used. #38072

Closed

Move (most) generated return statements for TH functions out of the switch. #38073

Closed

gchanan added 2 commits May 8, 2020 07:17

Update on "Kill resize-ing and zero-ing from codegen."

505c1c8

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

Update on "Kill resize-ing and zero-ing from codegen."

f3f95bf

All codegen invocations have been removed at this point, so this has no effect. Differential Revision: [D21433215](https://our.internmc.facebook.com/intern/diff/D21433215) [ghstack-poisoned]

facebook-github-bot closed this in c26dde9 May 11, 2020

facebook-github-bot added the merged label May 11, 2020

This was referenced May 11, 2020

Split up BinaryAritmeticKernel.cu to speed up compilation time. #38263

Closed

Move Cuda Abs kernel to its own file. #38274

Closed

Don't double dispatch on CUDA logical_not. #38275

Closed

facebook-github-bot deleted the gh/gchanan/270/head branch May 15, 2020 14:18

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Kill resize-ing and zero-ing from codegen. #37958

Kill resize-ing and zero-ing from codegen. #37958

Uh oh!

gchanan commented May 6, 2020 •

edited

Loading

Uh oh!

dr-ci bot commented May 6, 2020 •

edited

Loading

Uh oh!

bhosmer May 6, 2020

Uh oh!

facebook-github-bot commented May 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kill resize-ing and zero-ing from codegen. #37958

Kill resize-ing and zero-ing from codegen. #37958

Uh oh!

Conversation

gchanan commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci bot commented May 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CI failures summary and remediations

Uh oh!

bhosmer May 6, 2020

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented May 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gchanan commented May 6, 2020 •

edited

Loading

dr-ci bot commented May 6, 2020 •

edited

Loading