s/callUnboxed/call/ #37999
Closed
s/callUnboxed/call/ #37999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next step: make explicit type arguments less intrusive, or fine a way to eliminate them entirely. [ghstack-poisoned]
facebook-github-bot
added
the
oncall: jit
Next step: make explicit type arguments less intrusive, or fine a way to eliminate them entirely. Differential Revision: [D21445646](https://our.internmc.facebook.com/intern/diff/D21445646) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
May 7, 2020
Next step: make explicit type arguments less intrusive, or fine a way to eliminate them entirely. ghstack-source-id: e00143bbdc3fcb4c65a446344f556edd8ee14b7e Pull Request resolved: #37999
💊 CI failures summary and remediationsAs of commit 3d19bd9 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 9 times. |
smessmer
approved these changes
May 7, 2020
| @@ -31,7 +31,7 @@ static inline DispatchKey dispatchTypeId( | |||
| // - If there is no operator registered for a backend whose fallback behavior | |||
| // is to fallthrough, we eliminate that backend from consideration (since | |||
| // we want to "fallthrough" to the next valid key.) | |||
| // - If a user invokes with callUnboxedWithoutDispatchKey, the mask lets us | |||
| // - If a user invokes with callWithoutDispatchKey, the mask lets us | |||
There was a problem hiding this comment.
I think this mechanism is now called callUnboxedRedispatch?
Next step: make the explicit type arguments less intrusive, or find a way to eliminate them entirely. Differential Revision: [D21445646](https://our.internmc.facebook.com/intern/diff/D21445646) [ghstack-poisoned]
Next step: make the explicit type arguments less intrusive, or find a way to eliminate them entirely. Differential Revision: [D21445646](https://our.internmc.facebook.com/intern/diff/D21445646) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
May 7, 2020
Next step: make explicit type arguments less intrusive, or fine a way to eliminate them entirely. ghstack-source-id: 71f7121285b287a5d1cdd8e170da206742d4faf2 Pull Request resolved: #37999
Next step: make the explicit type arguments less intrusive, or find a way to eliminate them entirely. Differential Revision: [D21445646](https://our.internmc.facebook.com/intern/diff/D21445646) [ghstack-poisoned]
bhosmer
pushed a commit
that referenced
this pull request
May 8, 2020
Next step: make explicit type arguments less intrusive, or fine a way to eliminate them entirely. ghstack-source-id: cae714828ee5887dfba8ef2ae0ac1078314c6727 Pull Request resolved: #37999
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Next step: make the explicit type arguments less intrusive, or find
a way to eliminate them entirely.
Differential Revision: D21445646