Add minimal skeleton for _C type stubs, delete torch.autograd stub #38080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 7, 2020
Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 74ea46b037d51ac5bd13abd7bef0cd0eae5f65be Pull Request resolved: #38080
💊 CI failures summary and remediationsAs of commit 40fc6c3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker. This comment has been revised 17 times. |
…rad stub" Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 8, 2020
Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: 9e9e92e4dca7a8d1c1322020f38cb8dbb3c6f7e5 Pull Request resolved: #38080
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
rgommers
reviewed
May 8, 2020
…rad stub" Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
ezyang
added a commit
that referenced
this pull request
May 8, 2020
Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> ghstack-source-id: f55ab44411117e54eec753d541ed43d36c977e0c Pull Request resolved: #38080
rgommers
approved these changes
May 8, 2020
…rad stub" Originally, my plan was to just delete the torch.autograd stub, but this triggered a bunch of downstream errors relating to non-existent to _C modules, and so instead of ignoring those files, I decided to add a minimal _C type stubs, where it was easy (cases which were codegened I ignored). Signed-off-by: Edward Z. Yang <ezyang@fb.com> [ghstack-poisoned]
This was referenced May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Originally, my plan was to just delete the torch.autograd stub, but
this triggered a bunch of downstream errors relating to non-existent
to _C modules, and so instead of ignoring those files, I decided to
add a minimal _C type stubs, where it was easy (cases which were
codegened I ignored).
Signed-off-by: Edward Z. Yang ezyang@fb.com
Differential Revision: D21487841