[rpc] fix RRef alias annotation #39933
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. [ghstack-poisoned]
wanchaol
requested review from
apaszke,
mrshenli,
pritamdamania87 and
zhaojuanmao
as code owners
wanchaol
added a commit
that referenced
this pull request
Jun 12, 2020
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. ghstack-source-id: ef18cc7e8f87b2b15b7bde2087ba071fdb697170 Pull Request resolved: #39933
facebook-github-bot
added
the
oncall: jit
💊 CI failures summary and remediationsAs of commit 3e7b80e (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 11 times. |
mrshenli
approved these changes
Jun 12, 2020
| @@ -26,7 +26,7 @@ static auto workerInfo = | |||
|
|
|||
| RegisterOperators reg_rpc_ops( | |||
| {Operator( | |||
| "aten::to_here(RRef(t) self) -> t", | |||
| "aten::to_here(RRef(t) self) -> t(*)", | |||
There was a problem hiding this comment.
Curious, do we also change t to t(*) in RRef(t)?
There was a problem hiding this comment.
not needed, the change to the return type is to ensure the return value is aliased to any other values so that the dce will not remove this op, the RRef(t) does not need to alias to any other value like the return value
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. Differential Revision: [D22015426](https://our.internmc.facebook.com/intern/diff/D22015426) [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Jun 12, 2020
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. ghstack-source-id: 4769468b901599e1c4fac1ded0dbf90ba3bb4f05 Pull Request resolved: #39933
good point, |
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. Differential Revision: [D22015426](https://our.internmc.facebook.com/intern/diff/D22015426) [ghstack-poisoned]
wanchaol
added a commit
that referenced
this pull request
Jun 12, 2020
Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. ghstack-source-id: f046efb2005d5b299cda195cca4d90bec80cc374 Pull Request resolved: #39933
RockingJavaBean
added a commit
to RockingJavaBean/pytorch
that referenced
this pull request
Jun 14, 2020
Resolve the conflict of check_backward_compatibility.py from pull request pytorch#39933 Signed-off-by: Xiong Wei <xiongw.fnst@cn.fujitsu.com>
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Jun 20, 2020
Summary: Pull Request resolved: pytorch#39933 Fix rref related alias annotation to ensure it's not getting ebased by the jit dce. Test Plan: Imported from OSS Differential Revision: D22015426 Pulled By: wanchaol fbshipit-source-id: 3e74d49fa9f88abaf662bde7be5284f01f621b98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Fix rref related alias annotation to ensure it's not getting ebased by
the jit dce.
Differential Revision: D22015426