[quant] Reduce number of variants of add/mul #42769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Some of the quantized add and mul can have the same name Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 8, 2020
Summary: Some of the quantized add and mul can have the same name Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: d2afcc7edefd5e76613c80ce47d57132c420afc5 Pull Request resolved: #42769
💊 CI failures summary and remediationsAs of commit ec38153 (more details on the Dr. CI page):
ci.pytorch.org: 1 failedThis comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group. This comment has been revised 4 times. |
Summary: Some of the quantized add and mul can have the same name Test Plan: Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
jerryzh168
added a commit
that referenced
this pull request
Aug 11, 2020
Summary: Some of the quantized add and mul can have the same name Test Plan: Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 991533bfaa7fe68399ca16a1abbf7b594f4dc870 Pull Request resolved: #42769
supriyar
reviewed
Aug 11, 2020
| @@ -267,7 +267,14 @@ Tensor qadd_scalar_tensor_out(Tensor qa, Tensor b, Tensor out) { | |||
|
|
|||
| TORCH_LIBRARY_IMPL(quantized, QuantizedCPU, m) { | |||
| m.impl("add", TORCH_FN(qadd</*ReLUFused=*/false>)); | |||
| m.impl("add.out", TORCH_FN(qadd_out</*ReLUFused=*/false>)); | |||
| m.impl("add.Scalar", TORCH_FN(qadd_scalar</*ReLUFused=*/false>)); | |||
There was a problem hiding this comment.
Why Scalar and not scalar?
There was a problem hiding this comment.
this is following the naming of other overloaded functions in https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/native_functions.yaml
supriyar
approved these changes
Aug 11, 2020
|
This pull request has been merged in a846ed5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Summary:
Some of the quantized add and mul can have the same name
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags:
Differential Revision: D23054822