Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataPipe] Count number of successful yields for IterDataPipe #79657

Closed
wants to merge 10 commits into from

Conversation

NivekT
Copy link
Contributor

@NivekT NivekT commented Jun 15, 2022

Stack from ghstack:

This PR adds an attribute and logic to count the number of successful yields from IterDataPipe. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jun 15, 2022

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 55bdafc (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@NivekT NivekT added module: data torch.utils.data release notes: dataloader release notes category topic: not user facing topic category labels Jun 16, 2022
@NivekT NivekT changed the title [DataPipe] Count number of yields for IterDataPipe [DataPipe] Count number of successful yields for IterDataPipe Jun 20, 2022
@NivekT NivekT marked this pull request as ready for review June 20, 2022 22:10
@NivekT NivekT marked this pull request as draft June 21, 2022 17:11
Copy link
Contributor

@ejguan ejguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two comments below about bumping and reducing the counter.

torch/utils/data/datapipes/_hook_iterator.py Outdated Show resolved Hide resolved
torch/utils/data/datapipes/_hook_iterator.py Outdated Show resolved Hide resolved
…ipe"


This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

[ghstack-poisoned]
@NivekT NivekT marked this pull request as ready for review June 21, 2022 23:16
…ipe"


This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

[ghstack-poisoned]
…ipe"


This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

[ghstack-poisoned]
…ipe"


This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

[ghstack-poisoned]
@NivekT
Copy link
Contributor Author

NivekT commented Jun 28, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

@NivekT your PR has been successfully merged.

facebook-github-bot pushed a commit that referenced this pull request Jun 30, 2022
#79657)

Summary:
This PR adds an attribute and logic to count the number of successful yields from `IterDataPipe`. This information can be useful to fast-forward a DataPipe (or the entire graph) back to a certain state.

Pull Request resolved: #79657
Approved by: https://github.com/VitalyFedyunin

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/b8e50f512f735fb79b8b525cdb552e095a3873cb

Reviewed By: b0noI

Differential Revision: D37509831

Pulled By: NivekT

fbshipit-source-id: ad9f1bbcb43fc04d1d45135ec45a806dff8ff018
@facebook-github-bot facebook-github-bot deleted the gh/nivekt/52/head branch July 2, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants