Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ADD to COPY in Dockerfiles #82151

Closed
wants to merge 1 commit into from
Closed

Change ADD to COPY in Dockerfiles #82151

wants to merge 1 commit into from

Conversation

kit1980
Copy link
Member

@kit1980 kit1980 commented Jul 25, 2022

Docker docs says "For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY": https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

I've found this by running https://github.com/hadolint/hadolint

This is a follow-up after #81944

@kit1980 kit1980 requested a review from jeffdaily as a code owner July 25, 2022 19:42
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 25, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 60fa330 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@facebook-github-bot facebook-github-bot added the module: rocm AMD GPU support for Pytorch label Jul 25, 2022
@kit1980 kit1980 requested a review from a team July 25, 2022 19:42
@kit1980 kit1980 added the module: ci Related to continuous integration label Jul 25, 2022
@jeffdaily
Copy link
Collaborator

Are the CI failures real or transient?

jeffdaily
jeffdaily approved these changes Jul 25, 2022
View reviewed changes
Copy link
Collaborator

@jeffdaily jeffdaily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending a clean CI run.

@kit1980
Copy link
Member Author

kit1980 commented Jul 25, 2022

Are the CI failures real or transient?

Not transient but unrelated, I've created a separate issue #82174

ZainRizvi
ZainRizvi approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty cool!

@kit1980
Copy link
Member Author

kit1980 commented Jul 26, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased sdym/copy-add-2 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout sdym/copy-add-2 && git pull --rebase)

@kit1980
Copy link
Member Author

kit1980 commented Jul 26, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here

pytorchmergebot pushed a commit that referenced this pull request Jul 26, 2022
@kit1980 @pytorchmergebot
Change ADD to COPY in Dockerfiles (#82151)
b0b39b9 
Docker docs says "For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY": https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

I've found this by running https://github.com/hadolint/hadolint

This is a follow-up after #81944
Pull Request resolved: #82151
Approved by: https://github.com/huydhn, https://github.com/jeffdaily, https://github.com/ZainRizvi
@github-actions
Copy link
Contributor

Hey @kit1980.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 27, 2022
@kit1980 @facebook-github-bot
Change ADD to COPY in Dockerfiles (#82151) (#82151)
185d38e 
Summary:
Docker docs says "For other items (files, directories) that do not require ADD’s tar auto-extraction capability, you should always use COPY": https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#add-or-copy

I've found this by running https://github.com/hadolint/hadolint

This is a follow-up after #81944

Pull Request resolved: #82151
Approved by: https://github.com/huydhn, https://github.com/jeffdaily, https://github.com/ZainRizvi

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/8e926ff49e165095d01a6d7e72c25af96d927666

Reviewed By: osalpekar

Differential Revision: D38216248

Pulled By: kit1980

fbshipit-source-id: 83e66e55581099da037c61de3646a43c4e81de11
@kit1980 kit1980 deleted the sdym/copy-add-2 branch September 13, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZainRizvi ZainRizvi ZainRizvi approved these changes

@jeffdaily jeffdaily jeffdaily approved these changes

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
cla signed Merged module: ci Related to continuous integration module: rocm AMD GPU support for Pytorch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kit1980 @facebook-github-bot @jeffdaily @pytorchmergebot @huydhn @ZainRizvi