Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ONNX] Add 0d-tensor test case in runtime check #87212

Closed

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms commented Oct 18, 2022

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 18, 2022

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87212

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 80926c0:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

titaiwangms added a commit that referenced this pull request Oct 18, 2022
ghstack-source-id: d3aeca9a1dbdd5a66cf7db4b6842878bc1756dd7
Pull Request resolved: #87212
titaiwangms added a commit that referenced this pull request Oct 24, 2022
ghstack-source-id: 56ba1ba6a3d01544f2d11a136541e1ec4961a266
Pull Request resolved: #87212
@BowenBao
Copy link
Collaborator

Why no_runtime, does ort fail?

titaiwangms added a commit that referenced this pull request Oct 25, 2022
ghstack-source-id: 1d9e9189fd5f61e467c357d6469dbc9df4b5d968
Pull Request resolved: #87212
@titaiwangms titaiwangms changed the title [ONNX] Add 0d-tensor test case in no_runtime [ONNX] Add 0d-tensor test case in runtime check Oct 25, 2022
@titaiwangms
Copy link
Collaborator Author

titaiwangms commented Oct 25, 2022

Why no_runtime, does ort fail?

Good point, and moved.

My execuse lol => In the original issue, that was an exporter issue, and didn't even hit ORT, and I thought 0d output might break verification (thank God it's not). Though I checked the prediction result, I didn't put it in runtime.

@titaiwangms titaiwangms added the release notes: onnx torch.onnx related changes that should show up in the release notes label Oct 25, 2022
@titaiwangms
Copy link
Collaborator Author

@BowenBao PTAL

@titaiwangms
Copy link
Collaborator Author

@BowenBao PTAL. I moved the test to runtime.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 1, 2022
@titaiwangms
Copy link
Collaborator Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/AllenTiTaiWang/15/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/87212)

pytorchmergebot pushed a commit that referenced this pull request Nov 1, 2022
ghstack-source-id: 609921eb17e2eab8d480a264f2990ed0651a0302
Pull Request resolved: #87212
@titaiwangms
Copy link
Collaborator Author

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@facebook-github-bot facebook-github-bot deleted the gh/AllenTiTaiWang/15/head branch June 8, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants