Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message for instance norm when channels is incorrect #94624

Closed
wants to merge 6 commits into from
Closed

Improve error message for instance norm when channels is incorrect #94624

wants to merge 6 commits into from

Conversation

soulitzer
Copy link
Contributor

@soulitzer soulitzer commented Feb 10, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 10, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94624

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 Failures

As of commit 004afee:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@soulitzer soulitzer mentioned this pull request Feb 10, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Feb 10, 2023
This was referenced Feb 10, 2023
Closed
Closed
@albanD albanD removed their request for review February 14, 2023 20:09
@albanD
Copy link
Collaborator

albanD commented Feb 14, 2023

I'll let @jbschlosser review this one!

@soulitzer soulitzer mentioned this pull request Feb 15, 2023
Closed
soulitzer added a commit that referenced this pull request Feb 15, 2023
@soulitzer
Improve error message for instance norm when channels is incorrect
783f95b 
ghstack-source-id: 33b90ba17a72b26fb2a65e29700c59c42ba55b38
Pull Request resolved: #94624
@soulitzer soulitzer added ciflow/trunk Trigger trunk jobs on your pull request topic: improvements topic category labels Feb 15, 2023
jbschlosser
jbschlosser approved these changes Mar 3, 2023
View reviewed changes
Copy link
Contributor

@jbschlosser jbschlosser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! Looks good - just minor nits

test/test_nn.py Outdated Show resolved Hide resolved
torch/nn/modules/instancenorm.py Outdated Show resolved Hide resolved
soulitzer added a commit that referenced this pull request Mar 3, 2023
@soulitzer
Improve error message for instance norm when channels is incorrect
a96d231 
ghstack-source-id: 100724569b7ad7333a8e24f232e7306c713b080d
Pull Request resolved: #94624
@soulitzer
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-arm64 / test (default, 2, 2, macos-m1-12)

Details for Dev Infra team Raised by workflow job

@soulitzer
Copy link
Contributor Author

@pytorchbot merge -f "Unrelated failures"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@soulitzer @cyyever
Improve error message for instance norm when channels is incorrect (#…
dc7bebb 
…94624)

Fixes pytorch/pytorch#90514

Pull Request resolved: pytorch/pytorch#94624
Approved by: https://github.com/jbschlosser
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
Improve error message for instance norm when channels is incorrect (p…
252a5c6 
…ytorch#94624)

Fixes pytorch#90514

Pull Request resolved: pytorch#94624
Approved by: https://github.com/jbschlosser
@facebook-github-bot facebook-github-bot deleted the gh/soulitzer/183/head branch June 8, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbschlosser jbschlosser jbschlosser approved these changes

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: improvements topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@soulitzer @albanD @pytorchmergebot @jbschlosser