Deepcopy output node metadata #95426
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95426
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 0f29834: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| g.output(output_val, type_expr=getattr(old_output_val, 'type', None)) | ||
| output_val, old_output_node = output_vals | ||
| new_output_node = g.output(output_val, type_expr=getattr(old_output_node, 'type', None)) | ||
| new_output_node.meta = copy.copy(old_output_node.meta) |
There was a problem hiding this comment.
This should be done inside graph_copy.
see line 780
There was a problem hiding this comment.
I think that might break BC because the way graph_copy is implemented, it isn't meant to copy over the output node.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95426 Approved by: https://github.com/SherlockNoMad
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95426 Approved by: https://github.com/SherlockNoMad
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95426 Approved by: https://github.com/SherlockNoMad
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95426 Approved by: https://github.com/SherlockNoMad
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95426 Approved by: https://github.com/SherlockNoMad
This reverts commit d301caa.
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95426 Approved by: https://github.com/SherlockNoMad
Fixes #ISSUE_NUMBER