Add google analytics support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malfet
approved these changes
Apr 12, 2021
This was referenced Apr 12, 2021
This was referenced Apr 20, 2021
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
May 4, 2021
Summary: This PR fixes the GA id and relies on `pytorch-sphinx-theme` to set the GA script instead of hard-coding it (this is supported since pytorch/pytorch_sphinx_theme#110 was merged). Similar PRs were opened and merged in torchchvision/audio/text, e.g.: pytorch/vision#3700 CC brianjo Pull Request resolved: #56578 Reviewed By: mrshenli Differential Revision: D28199244 Pulled By: ranman fbshipit-source-id: a20b7fd1b1da3ebff491286c3eeb1410f3c80670
krshrimali
pushed a commit
to krshrimali/pytorch
that referenced
this pull request
May 19, 2021
Summary: This PR fixes the GA id and relies on `pytorch-sphinx-theme` to set the GA script instead of hard-coding it (this is supported since pytorch/pytorch_sphinx_theme#110 was merged). Similar PRs were opened and merged in torchchvision/audio/text, e.g.: pytorch/vision#3700 CC brianjo Pull Request resolved: pytorch#56578 Reviewed By: mrshenli Differential Revision: D28199244 Pulled By: ranman fbshipit-source-id: a20b7fd1b1da3ebff491286c3eeb1410f3c80670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109
This PR adds GA support to the theme via the
analytics_idconfig option, which was documented but ignored: https://github.com/pytorch/pytorch_sphinx_theme/blob/8eff7df04b7fe5bc5173daa5031b94e062d5fc64/docs/configuring.rst .The solution is inspired from https://www.ericholscher.com/blog/2009/apr/5/adding-google-analytics-sphinx-docs/ and uses a more modern script as recommended in https://developers.google.com/analytics/devguides/collection/analyticsjs#alternative_async_tag