Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css tweaks #135

Merged
merged 2 commits into from
Aug 2, 2021
Merged

Css tweaks #135

merged 2 commits into from
Aug 2, 2021

Conversation

mattip
Copy link
Contributor

@mattip mattip commented Aug 1, 2021

Fix issue #129: add a small margin around admonitions for nested directives

Fix issue #130: do not set background color for spans within admonitions (like double-backticked "pre" spans).

@mattip
Copy link
Contributor Author

mattip commented Aug 3, 2021

No, this didn't work and should probably be reverted. I don't understand the interplay between the scss/_sphinx_base.scss file and the pytorch_sphinx_theme/static/css/theme.css. Both are checked in to git, but it seems the second is meant to be generated? I could not get grunt to work locally. It seems #134 modified both files, but doesn't the CI rebuild the theme.css from grunt here?

- run: grunt build

@mattip mattip mentioned this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants