Allow images to define width #142
Conversation
|
@brianjo can you review this? |
|
@patmellon can you review this? |
|
As far as I know, this repo is seldom maintained... You may propose the issue in pytorch main repo to gain more attention, if you think the modification is worth review asap. I think this PR worth review, since the previous theme can't change image width. (but maybe not your another PR about footer modification, which is really minor.) |
|
Adam, could you post a before and after screen so I can see what the difference is? I'll take a look on Monday and merge it after I run some tests. Thanks for the contribution! |
|
I've tested this modification. Before this PR, all images are with 100% width, even you have written in the rst file with .. image:: ./XXX.jpg
:width: 60%The generated html img tag is corrected with <img alt="XXX.jpg" src="XXX.jpg" width="60%">But it won't take effect because the there's style with article.pytorch-article img {
width: 100%;
}Removing this style makes it work again. (You could see that from his changes) |
That's unfortunate, as I think this is a great Sphinx theme and a lot of projects rely on it, including my own. I don't think I know enough about web dev to help maintain this project, but if there's anything else I can do to help let me know. I would love to see this theme install correctly without having to copy it into the root of the documentation. |
|
It’s not really that. It’s a custom fork of the read the docs theme especially made for the PyTorch sites, so we usually don’t update it unless we see a problem. It’s a really nice theme though and I think that it would be great if somebody forked it and created a new, generic theme that could be maintained by the community.
…________________________________
From: Adam J. Stewart ***@***.***>
Sent: Sunday, October 17, 2021 12:17:27 PM
To: pytorch/pytorch_sphinx_theme ***@***.***>
Cc: Brian Johnson ***@***.***>; Mention ***@***.***>
Subject: Re: [pytorch/pytorch_sphinx_theme] Allow images to define width (#142)
As far as I know, this repo is seldom maintained...
That's unfortunate, as I think this is a great Sphinx theme and a lot of projects rely on it, including my own<https://torchgeo.readthedocs.io/>. I don't think I know enough about web dev to help maintain this project, but if there's anything else I can do to help let me know. I would love to see this theme install correctly without having to copy it into the root of the documentation.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALOH5ON3T5D6PVXS6O76IDUHLZJPANCNFSM5DL5UNVQ>.
|
|
I'm currently working on my trojanzoo_sphinx_theme, which removes all pytorch-related items, and making it a pure doc theme. You can customized most things in your sphinx workspace, including logo images and permalinks (home, docs, other docs, and github_url) inside. I've fixed many bugs I've seen, and propose PR to pytorch_sphinx_theme if possible. And I also add some minor visual changes. You may take a look if you are interested. Example: A demo: https://ain-soph.github.io/trojanzoo_sphinx_theme/ |
|
Oh that’s awesome. I’ll be sure to share if someone asks about a generic version.
…________________________________
From: Ren Pang ***@***.***>
Sent: Sunday, October 17, 2021 12:47:02 PM
To: pytorch/pytorch_sphinx_theme ***@***.***>
Cc: Brian Johnson ***@***.***>; Mention ***@***.***>
Subject: Re: [pytorch/pytorch_sphinx_theme] Allow images to define width (#142)
I'm currently working on my trojanzoo_sphinx_issue<https://github.com/ain-soph/trojanzoo_sphinx_theme>, which removes all pytorch-related items, and making it a pure doc theme. You can customized most things in your sphinx workspace, including logo images and permalinks (home, docs, other docs, and github_url) inside.
I've fixed many bugs I've seen, and propose PR to pytorch_sphinx_theme if possible. And I also add some minor visual changes. You may take a look if you are interested.
Example:
A demo: https://ain-soph.github.io/trojanzoo_sphinx_theme/<https://ain-soph.github.io/trojanzoo_sphinx_theme/>
My python plotting package: https://ain-soph.github.io/alpsplot/<https://ain-soph.github.io/alpsplot/>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#142 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AALOH5LTDKMGXIKE5F33VF3UHL4YNANCNFSM5DL5UNVQ>.
|
|
This looks great! I probably won't switch to this until the rest of the PyTorch community switches though. Trying to maintain some semblance of uniformity in docs. Is the PyTorch community willing to switch to this? It seems pointless to have two repos if we have to submit bug fixes to both. |
I'm not expecting to this though. Currently |
Yes, this is exactly what I'm hoping for. Since my project is also a PyTorch domain library, I would like to keep my docs consistent with the other ones. I think this also represents a best case for the PyTorch devs too since they won't have to maintain this repo anymore. |
|
Closing this as it seems that this repo is not maintained. We're starting to seriously consider the |
Fixes #140. See #140 for details.
@calebrob6